gh-124153: Remove _PyType_GetModuleByDef2 private function#124262
Closed
neonene wants to merge 3 commits intopython:mainfrom
neonene:byedef2
Closed
gh-124153: Remove _PyType_GetModuleByDef2 private function#124262neonene wants to merge 3 commits intopython:mainfrom neonene:byedef2
_PyType_GetModuleByDef2 private function#124262neonene wants to merge 3 commits intopython:mainfrom
neonene:byedef2
Conversation
6 tasks
vstinner
reviewed
Sep 20, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
You must update Modules/_decimal/_decimal.c: see the warnings.
Member
|
I suggest to mark this PR as a draft and wait until #124261 is merged. |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Migrated to #124261. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was introduced in #117578, which will no longer be used superseded by #124261.
cc @encukou
PyType_GetBaseByTokenfunction withPy_tp_tokenslot #124153